Remove imgui_impl_opengl3 from polyscope.cpp#342
Merged
nmwsharp merged 1 commit intonmwsharp:masterfrom Jul 19, 2025
Merged
Conversation
Owner
|
Thanks for this. I'm not sure what that is doing there, but agreed it doesn't make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should cause a bug when building unit tests, since they don't rely on the opengl backend (due to
POLYSCOPE_BACKEND_OPENGL_MOCK_ENABLED) and therefore shouldn't link to this particular imgui backend.I'm not sure why cmake permits this, but this causes the build to break when using Bazel (which is the correct behaviour).